MediaWiki:Common.js - Revision history

Hywell: Changing scrollIntoView to be centered instead

2024-12-14T02:38:30Z

Changing scrollIntoView to be centered instead

2024-12-14T02:10:08Z

Bug fix - adding missing quotation marks

2024-12-14T02:08:28Z

Bug fix for tabberGoTo replace function

2024-12-14T01:49:26Z

2024-12-14T01:45:33Z

2024-12-14T00:21:33Z

2024-12-14T00:20:03Z

Adding a comment describing the tabberGoTo function

2024-12-14T00:18:48Z

2024-12-14T00:14:45Z

Replacing for of loop with for each...

2024-12-14T00:13:20Z

Replacing arrow functions with regular functions...

@@ Line 23: / Line 23: @@
      if (id) {
-         document.getElementById(id).scrollIntoView({ behavior: "smooth", block: "start" })
+         document.getElementById(id).scrollIntoView({ behavior: "smooth", block: "center" })
+     }
+}

@@ Line 30: / Line 30: @@
 Array.from(document.getElementsByClassName('tabberGoTo')).forEach(function (element) {
      const newElement = document.createElement('a')
-     newElement.setAttribute('onclick', "tabberGoTo(this, " + element.classList[1] + ", " + element.id + ")")
+     newElement.setAttribute('onclick', "tabberGoTo(this, '" + element.classList[1] + "', '" + element.id + "')")
      newElement.textContent = element.textContent

@@ Line 30: / Line 30: @@
 Array.from(document.getElementsByClassName('tabberGoTo')).forEach(function (element) {
      const newElement = document.createElement('a')
-     newElement.setAttribute('onclick', "tabberGoTo(this, " + element.classList[0] + ", " + element.id + ")")
+     newElement.setAttribute('onclick', "tabberGoTo(this, " + element.classList[1] + ", " + element.id + ")")
      newElement.textContent = element.textContent

@@ Line 30: / Line 30: @@
 Array.from(document.getElementsByClassName('tabberGoTo')).forEach(function (element) {
      const newElement = document.createElement('a')
-     newElement.setAttribute('onclick', `tabberGoTo(this, ${element.classList[1]}, ${element.id})`)
+     newElement.setAttribute('onclick', "tabberGoTo(this, " + element.classList[0] + ", " + element.id + ")")
      newElement.textContent = element.textContent

@@ Line 26: / Line 26: @@
+     }
+}
 /* Replaces currency keywords (Gold, Gems, Defender Medals) with their icon in elements which include currency costs */

@@ Line 8: / Line 8: @@
+     }
-     const tabberParent = tabbertab.parentElement
+     const tabber = tabbertab.parentElement
-     const tabberChildren = Array.from(tabberParent.children)
+     const tabberChildren = Array.from(tabber.children)
      // Switch tabs

@@ Line 1: / Line 1: @@
 /* Any JavaScript here will be loaded for all users on every page load. */
 function tabberGoTo(thisElement, tabName, id) {
      var tabbertab = thisElement

@@ Line 16: / Line 16: @@
      // Handle tabbernav CSS
      const nav = tabberChildren.find(function (child) { return child.classList.contains('tabbernav') })
-     for (const child of Array.from(nav.children)) {
+     Array.from(nav.children).forEach(function (child) {
          if (child.firstElementChild.title === tabbertab.title) { child.classList = '' }
          if (child.firstElementChild.title === tabName) { child.classList = 'tabberactive' }
+     })
      document.getElementById(id).scrollIntoView({ behavior: "smooth", block: "start" })

@@ Line 12: / Line 12: @@
      // Switch tabs
      tabbertab.style.display = 'none'
-     tabberChildren.find(child => child.title === tabName).style.display = 'block'
+     tabberChildren.find(function (child) { return child.title === tabName }).style.display = 'block'
      // Handle tabbernav CSS
-     const nav = tabberChildren.find(child => child.classList.contains('tabbernav'))
+     const nav = tabberChildren.find(function (child) { return child.classList.contains('tabbernav') })
      for (const child of Array.from(nav.children)) {
          if (child.firstElementChild.title === tabbertab.title) { child.classList = '' }
@@ Line 21: / Line 21: @@
+     }
-     document.getElementById(id).scrollIntoView({ behavior: "smooth", block: "end" })
+     document.getElementById(id).scrollIntoView({ behavior: "smooth", block: "start" })
+}